Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Net] Fix socket poll timeout on Windows. #48203

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Apr 26, 2021

Now correctly computes the timeout value in milliseconds.

Fixes #48195

Now correctly computes the timeout value in milliseconds.
@Faless Faless added bug platform:windows topic:network cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Apr 26, 2021
@Faless Faless added this to the 4.0 milestone Apr 26, 2021
@akien-mga akien-mga merged commit 1943d2b into godotengine:master Apr 27, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Apr 29, 2021
@akien-mga
Copy link
Member

Cherry-picked for 3.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent timeout unit in NetSocketPosix::poll
2 participants